Skip to content

[service-utils] fix: Add LZ4 package for usageV2 compression #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2025
Merged

[service-utils] fix: Add LZ4 package for usageV2 compression #6121

merged 5 commits into from
Jan 30, 2025

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jan 30, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces support for LZ4 compression in the UsageV2Producer class of the service-utils package, enhancing the Kafka producer's capabilities. It also updates dependencies to include kafkajs-lz4 for this functionality.

Detailed summary

  • Added LZ4Codec import from kafkajs-lz4.
  • Introduced compression property in UsageV2Producer constructor.
  • Default compression set to LZ4.
  • Updated Kafka producer configuration to use LZ4 codec when specified.
  • Updated pnpm-lock.yaml to include kafkajs-lz4 dependency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested review from a team as code owners January 30, 2025 22:32
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 51ffb00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 11:00pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 11:00pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 11:00pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 11:00pm

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Jan 30, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@socket-security
Copy link

socket-security bot commented Jan 30, 2025 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, network, shell +17 813 kB gprasannah

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 2.4 s (-12.23% 🔽) 3.3 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 6.5 s (+2.33% 🔺) 8.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 743 ms (+258.35% 🔺) 854 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 51 ms (+18.15% 🔺) 61 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 697 ms (+21.2% 🔺) 1.1 s

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 30, 2025 22:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 30, 2025 22:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 30, 2025 22:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 30, 2025 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 30, 2025 22:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 30, 2025 22:43 Inactive
@codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (a22457a) to head (51ffb00).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6121   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5180     5180           
=======================================
  Hits        36344    36344           
  Misses      26825    26825           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a22457a
packages 55.07% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@arcoraven arcoraven merged commit 6ed2fd1 into main Jan 30, 2025
28 of 30 checks passed
@arcoraven arcoraven deleted the ph/importLz4 branch January 30, 2025 22:55
@joaquim-verges joaquim-verges mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arcoraven arcoraven

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arcoraven